add sqrt(4pi) factor to magnetic field unit conversion #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenWibking
changed the title
pgrete
approved these changes
Nov 8, 2024
|
I also checked the code neither |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internally, AthenaPK (and almost all MHD codes) use Heaviside-Lorentz units, where the magnetic field is transformed from$B \rightarrow B / \sqrt{4 \pi}$ . (See also the note in the Castro documentation about this.)
So when converting from CGS-Gaussian units to code units, it is necessary to divide by$\sqrt{4 \pi}$ (in addition to the base dimensional factors).
When converting from code units to CGS-Gaussian units, it is necessary to multiply by$\sqrt{4 \pi}$ (in addition to the base dimensional factors).